thesmallstar commented on a change in pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#discussion_r453976595
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java
##########
@@ -257,22 +257,22 @@ public void testSavingsAccount_WITH_ENFORCE_MIN_BALANCE()
{
DateFormat dateFormat = new SimpleDateFormat("dd MMMM yyyy");
Calendar todaysDate = Calendar.getInstance();
- final String TRANSACTION_DATE =
dateFormat.format(todaysDate.getTime());
+ final String transactionDateValue =
dateFormat.format(todaysDate.getTime());
Review comment:
Edit: I am speaking wrong here, please ignore.
@vorburger in that case:
This would clash with AbbreviationAsWordInName checkstyle which only allows
up to 4 capital letters in final variables.
What should we go with?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
