vidakovic commented on a change in pull request #1292:
URL: https://github.com/apache/fineract/pull/1292#discussion_r478220925



##########
File path: README.md
##########
@@ -353,6 +353,41 @@ Releasing
 
 [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) 
documents the process how we make the source code that is available here in 
this Git repository into a binary release ZIP available on 
http://fineract.apache.org.
 
+Before you use Gradle to create a release you need to make sure that your GPG 
is properly setup and that you have set the following properties in your 
~/gradle/gradle.properties:
+```
+signing.gnupg.keyName=7890ABCD
+signing.gnupg.passphrase=secret
+```
+
+IMPORTANT: Do not set your GPG secrets in one of the project gradle.properties 
and double check that you are not accidentally committing them to Git.
+
+NOTE: Let's assume your GPG key ID would be 
"ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890ABCD" then you have to use the last 8 
characters (i. e. "7890ABCD") for the signing plugin property 
"signing.gnupg.keyName". 
+
+Execute the following task to create a distribution with an ASCII armored 
signature (.asc) and a SHA512 checksum file (.sha512):
+```
+./gradlew -Pfineract.release clean build 
+```

Review comment:
       I had that conversation with  @edcable and it was preferred to include 
this "naturally" (i. e. without a specific task) in the build process. Note: 
the release artifacts are only created when "-Pfineract.release" is provided on 
the command line which is pretty explicit. For the next release I intend to add 
even more features here (publishing client jar on Maven Central, uploading 
distribution to Apache, maybe publishing release Confluence page).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to