vidakovic commented on a change in pull request #1292:
URL: https://github.com/apache/fineract/pull/1292#discussion_r478241724



##########
File path: README.md
##########
@@ -353,6 +353,41 @@ Releasing
 
 [How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) 
documents the process how we make the source code that is available here in 
this Git repository into a binary release ZIP available on 
http://fineract.apache.org.
 
+Before you use Gradle to create a release you need to make sure that your GPG 
is properly setup and that you have set the following properties in your 
~/gradle/gradle.properties:
+```
+signing.gnupg.keyName=7890ABCD
+signing.gnupg.passphrase=secret
+```
+
+IMPORTANT: Do not set your GPG secrets in one of the project gradle.properties 
and double check that you are not accidentally committing them to Git.
+

Review comment:
       I've added a clarification to the README describing both ways to provide 
the necessary parameters (either in your home gradle.properties or via command 
line).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to