vidakovic commented on a change in pull request #1292:
URL: https://github.com/apache/fineract/pull/1292#discussion_r478224103
##########
File path: fineract-provider/gradle.properties
##########
@@ -16,5 +16,5 @@
# specific language governing permissions and limitations
# under the License.
#
-releaseVersion=1.0.0
+releaseVersion=1.4.0
buildType=BUILD
Review comment:
I saw that you use a Gradle version plugin to do this and I actually
prefer that way. For this release I'll leave it to the hard coded version
number, but would suggest your method for the whole project. Note: the version
of the client JAR in the release branch is not correct (shows something like
"client-1.3.0-xyz-dirty.jar"; I do understand that it creates that based on the
last release tag; we just have to make sure that this works correctly when the
release build is running (release tag 1.4.0 has to exist).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
