vidakovic commented on a change in pull request #1402:
URL: https://github.com/apache/fineract/pull/1402#discussion_r505508035



##########
File path: build.gradle
##########
@@ -20,6 +20,16 @@
 buildscript {
     ext {
         jacocoVersion = '0.8.5'
+        retrofitVersion = '2.9.0'
+        okhttpVersion = '4.7.2'
+        oltuVersion = '1.0.1'

Review comment:
       OKHttp doesn't generate anything, but we are still building the client 
JAR... so unless I'm missing something here seems to be normal to me...
   
   Before it was not defined in Fineract's dependency management section, 
because the build was driven by a totally independent - single project - Maven 
pom.xml that had no ties to the fineract project setup (in terms of 
dependencies).
   
   These dependencies are just a consequence of having fineract-client as a 
module.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to