ptuomola commented on a change in pull request #1994:
URL: https://github.com/apache/fineract/pull/1994#discussion_r766938895
##########
File path:
fineract-provider/src/main/resources/sql/migrations/core_db/V265__modify_external_service_schema.sql
##########
@@ -53,9 +53,9 @@ insert into c_external_service_properties (`name`, `value`,
`external_service_id
insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('password', 'support80', (select id from
c_external_service where name = 'SMTP_Email_Account'));
-insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('host', 'smtp.gmail.com', (select id from
c_external_service where name = 'SMTP_Email_Account'));
+insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('host', 'localhost', (select id from
c_external_service where name = 'SMTP_Email_Account'));
-insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('port', '587', (select id from c_external_service
where name = 'SMTP_Email_Account'));
+insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('port', '3025', (select id from
c_external_service where name = 'SMTP_Email_Account'));
Review comment:
The reason why I chose this "unorthodox" approach is that we don't want
to overwrite people's existing SMTP configurations. We only want to change the
default for new systems that is used in testing. So we don't want to
migrate/change any existing setups (as adding a new migration script would do),
we want to just change the value that is used when setting up a new system...
Another approach would be to have some custom SQL overwriting the initial
values in testing. But as no one should be using the initial values anyway in
their systems, why not just change them...
##########
File path: twofactor-tests/build.gradle
##########
@@ -0,0 +1,67 @@
+/**
Review comment:
I tried to initially do something along those lines i.e. have one master
cargo task and then inherit from that. I couldn't get it to work so thought
it's easier just to have two parallel projects with no dependencies between
them. But I'm not very good with Gradle so very happy if someone can do
something more elegant...
##########
File path:
twofactor-tests/src/test/java/org/apache/fineract/twofactortests/common/Utils.java
##########
@@ -0,0 +1,267 @@
+/**
Review comment:
I'm only using two methods from that so can inline them into the other
class and delete this.
I agree that it would be good to move away from restassured etc. But I
haven't spent much time with fineract-client yet, and just wanted to quickly
come up with something that stops us from accidentally breaking non-basicauth
profiles - as we had recently done without noticing. Very happy if someone
wants to do this better ie with fineract-client etc...
##########
File path:
twofactor-tests/src/test/java/org/apache/fineract/twofactortests/common/Utils.java
##########
@@ -0,0 +1,267 @@
+/**
Review comment:
Done... took me a bit longer than I expected, as I found a time rounding
error in the code as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
