vorburger commented on a change in pull request #1994:
URL: https://github.com/apache/fineract/pull/1994#discussion_r767209408
##########
File path:
twofactor-tests/src/test/java/org/apache/fineract/twofactortests/common/Utils.java
##########
@@ -0,0 +1,267 @@
+/**
Review comment:
SGTM. Do you want to do that (inline) and I'll merge this?
##########
File path: twofactor-tests/build.gradle
##########
@@ -0,0 +1,67 @@
+/**
Review comment:
SGTM. Maybe this is a clean up that e.g. @vidakovic who has great Gradle
foo ;) wants to do as a follow up after this is merged.
##########
File path:
fineract-provider/src/main/resources/sql/migrations/core_db/V265__modify_external_service_schema.sql
##########
@@ -53,9 +53,9 @@ insert into c_external_service_properties (`name`, `value`,
`external_service_id
insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('password', 'support80', (select id from
c_external_service where name = 'SMTP_Email_Account'));
-insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('host', 'smtp.gmail.com', (select id from
c_external_service where name = 'SMTP_Email_Account'));
+insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('host', 'localhost', (select id from
c_external_service where name = 'SMTP_Email_Account'));
-insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('port', '587', (select id from c_external_service
where name = 'SMTP_Email_Account'));
+insert into c_external_service_properties (`name`, `value`,
`external_service_id`) values('port', '3025', (select id from
c_external_service where name = 'SMTP_Email_Account'));
Review comment:
SGTM, then we'll do this as an "exception to the rule".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
