galovics commented on code in PR #2288:
URL: https://github.com/apache/fineract/pull/2288#discussion_r856330810
##########
fineract-provider/src/main/resources/application.properties:
##########
@@ -99,7 +99,7 @@
spring.datasource.hikari.dataSourceProperties['dumpQueriesOnException']=${FINERA
spring.jpa.open-in-view=false
# Liquibase configuration
-spring.liquibase.enabled=true
+spring.liquibase.enabled=${fineract.mode.write-enabled}
Review Comment:
Oh okay, I get it now. The default Liquibase migration you're used to is
actually disabled because the AutoConfiguration is excluded from the Spring
context (see `AbstractApplicationConfiguration`). Essentially the only
Liquibase migration done is within the `TenantDatabaseUpgradeService` where you
have the check exactly if the instance is a write instance.
The reason the property is there in the application.properties is because
the `TenantDatabaseUpgradeService` checks this same property whether the
migration should be enabled/disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
