galovics commented on code in PR #2288:
URL: https://github.com/apache/fineract/pull/2288#discussion_r858858546
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/LiquibaseStepDefinitions.java:
##########
@@ -99,9 +106,18 @@ public LiquibaseStepDefinitions() {
Then("The database migration did not do anything", () -> {
verify(databaseStateVerifier).isLiquibaseDisabled();
+ verify(fineractProperties).getMode();
verifyNoMoreInteractions(databaseStateVerifier);
- verifyNoInteractions(tenantDetailsService, tenantStoreDataSource,
fineractProperties, liquibaseFactory,
- tenantDataSourceFactory);
+ verifyNoMoreInteractions(fineractProperties);
+ verifyNoInteractions(tenantDetailsService, tenantStoreDataSource,
liquibaseFactory, tenantDataSourceFactory);
+ });
+
+ Then("The database migration did not do anything, because it is not a
write instance", () -> {
Review Comment:
Just a note: since this is related to liquibase, you can leave it here
instead of moving this into the other class I mentioned above.
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/LiquibaseStepDefinitions.java:
##########
@@ -65,6 +65,13 @@ public LiquibaseStepDefinitions() {
});
Given("Liquibase is enabled with a default tenant", () -> {
initializeLiquibase(true);
+ initializeWriteInstance();
Review Comment:
Let's create a new StepDefinitions class for the isntance types, like
InstanceTypeStepDefinitions that only stores the related functionalities.
Technically what you implemented works but it's definitely not at the right
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
