galovics commented on code in PR #2288:
URL: https://github.com/apache/fineract/pull/2288#discussion_r859734534
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/LiquibaseStepDefinitions.java:
##########
@@ -158,7 +164,8 @@ private void initializeLiquibase(boolean liquibaseEnabled) {
defaultTenantDataSource = mock(DataSource.class);
given(databaseStateVerifier.isLiquibaseDisabled()).willReturn(!liquibaseEnabled);
- given(fineractProperties.getTenant()).willReturn(new
FineractProperties.FineractTenantProperties());
+ // given(fineractProperties.getTenant()).willReturn(new
FineractProperties.FineractTenantProperties());
Review Comment:
comments.
##########
fineract-provider/src/test/resources/application-test.properties:
##########
@@ -33,6 +33,10 @@ fineract.tenant.identifier=default
fineract.tenant.name=fineract_default
fineract.tenant.description=Default Demo Tenant
+fineract.mode.read-enabled=${FINERACT_MODE_READ_ENABLED:true}
Review Comment:
You can skip using the env vars for the tests. Nobody is using them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
