galovics commented on code in PR #2314:
URL: https://github.com/apache/fineract/pull/2314#discussion_r869993919
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/system/DatatableHelper.java:
##########
@@ -48,6 +48,19 @@ public String createDatatable(final String apptableName,
final boolean multiRow)
getTestDatatableAsJSON(apptableName, multiRow),
"resourceIdentifier");
}
+ public Integer createDatatableEntry(final String apptableName, final
String datatableName, final Integer apptableId,
Review Comment:
This method is not called anywhere in your test.
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/organisation/EntityDatatableChecksIntegrationTest.java:
##########
@@ -81,6 +81,26 @@ public void setup() {
this.datatableHelper = new DatatableHelper(this.requestSpec,
this.responseSpec);
}
+ @Test
+ public void validateCreateReadDeleteDatatableCheck() {
Review Comment:
I don't think this test-case covers the changed functionality that the
datetimes are converted properly.
Could you please explain if I'm wrong there and point out how it's covered?
Thanks!
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/system/DatatableHelper.java:
##########
@@ -48,6 +48,19 @@ public String createDatatable(final String apptableName,
final boolean multiRow)
getTestDatatableAsJSON(apptableName, multiRow),
"resourceIdentifier");
}
+ public Integer createDatatableEntry(final String apptableName, final
String datatableName, final Integer apptableId,
+ final boolean genericResultSet, final String dateFormat) {
+ return Utils.performServerPost(
+ this.requestSpec, this.responseSpec, DATATABLE_URL + "/" +
datatableName + "/" + apptableId + "?genericResultSet="
+ + Boolean.toString(genericResultSet) + "&" +
Utils.TENANT_IDENTIFIER,
+ getTestDatatableEntryAsJSON(dateFormat), "resourceId");
+ }
+
+ public String readDatatableEntry(final String datatableName, final Integer
resourceId, final boolean genericResultset) {
Review Comment:
This method is not called anywhere in your test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
