josehernandezfintecheandomx commented on code in PR #2314:
URL: https://github.com/apache/fineract/pull/2314#discussion_r873824689


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java:
##########
@@ -262,4 +261,14 @@ private SqlRowSet getDatatableMetaData(final String 
datatable) {
             throw new DatatableNotFoundException(datatable);
         }
     }
+
+    private String formatDateTimeValue(String dateTimeValue) {

Review Comment:
   There are three cases due three different databases, two are same length the 
third one has more data then is more longer, and in between the two similars 
the difference is the T
   Maybe you are right in terms to have a better solution reading the dates as 
dates, numbers as numbers instead of just strings, but It can to impact no just 
the API, can to impact the front end too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to