galovics commented on code in PR #2314:
URL: https://github.com/apache/fineract/pull/2314#discussion_r873830520


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java:
##########
@@ -262,4 +261,14 @@ private SqlRowSet getDatatableMetaData(final String 
datatable) {
             throw new DatatableNotFoundException(datatable);
         }
     }
+
+    private String formatDateTimeValue(String dateTimeValue) {

Review Comment:
   Yeah so my idea is to read dates as dates from the database and everything 
else as strings (for now at least) and use the existing date format on the API 
level so we don't break anything.
   
   How I'd imagine, this is where we are right now:
   Database -> string reading -> preparing the generic resultset -> format the 
strings -> send back on the API
   Instead, let's do
   Database -> string or date reading -> preparing the generic resultset -> 
format the date -> send back on the API
   
   Hope that explains.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to