taskain7 commented on PR #2437: URL: https://github.com/apache/fineract/pull/2437#issuecomment-1189996070
Hi Awasum, thank you for raising this topic, you are totally right. I’ve opened a JIRA ticket for this improvement, and I will rename my PR to title that contains the JIRA ticket number. Tests are not needed, because we have existing test for the jobs, and the jobs’ behavior have not changed at all. After my PR is merged, I will write an e-mail to the mail list about the changes, and Ascii Doc will be extended with Spring Batch soon. Sincerely, Norbert > 2022. júl. 19. dátummal, 20:10 időpontban Awasum Yannick ***@***.***> írta: > > > Thanks for the beautiful contributions @taskain7 <https://github.com/taskain7> > Please..is there a Fineract JIRA ticket for this one? I know it can be annoying but open source projects depend on them for continuity and transparency. Having a JIRA ticket describing the use case and issue you are solving will be a great idea. Also good idea to add unit/integration tests (it may already be there) and documentation on how to use this feature. Future users will be grateful for this and it will make it easy for others to contribute..extend this..even you one year from today will benefit from this. link to create issues: https://issues.apache.org/jira/projects/FINERACT/issues <https://issues.apache.org/jira/projects/FINERACT/issues> > cc @adamsaghy <https://github.com/adamsaghy> , @galovics <https://github.com/galovics> , @vidakovic <https://github.com/vidakovic> , @ptuomola <https://github.com/ptuomola> , @edcable <https://github.com/edcable> , @fynmanoj <https://github.com/fynmanoj> , @avikganguly01 <https://github.com/avikganguly01> , @vorburger <https://github.com/vorburger> > — > Reply to this email directly, view it on GitHub <https://github.com/apache/fineract/pull/2437#issuecomment-1189401054>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFBXE6F36KRQ4K673GQUCWTVU3VRJANCNFSM54AALHSQ>. > You are receiving this because you were mentioned. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
