fynmanoj commented on PR #2437: URL: https://github.com/apache/fineract/pull/2437#issuecomment-1195090973
1. Similar to how liquibase was not intended to change any data , this wont change the functionality of the batch job intentionally . But there would be unintentional consequences to users who don’t want to be impacted by infra changes. 2. Can you please integration test for one of the batch job honoring the job Params for batch size. 3. In the future, can similar pull requests be split into multiple pull request based on the feature it addresses, to make it easily reviewable 4. Since it is a big change , I think we need to create 1.8.0 to separate from the cutting edge stuff going on develop, before this pull request get merged. To avoid large test cycle of 1.8.0 relese -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
