fynmanoj commented on PR #2437:
URL: https://github.com/apache/fineract/pull/2437#issuecomment-1195247727
@galovics :
Thanks for your response, let me try to clarify what I meant above.
> By `"infra changes"`
I mean the major framework level changes that can affect the users and
deployments.
> Elaborate please. What batch size?
There are Job level configurations added to the jobs as job parameters.
These include the batch size, thread pool etc. there are jobs that require
these parameters. While adding a framework level change, It would be helpful to
test the sanity of these configs.
In this PR other than the Batch changes, I could see some other changes like
Sl4j related(in test cases mainly this is the only change.). Can't these be two
different PRs?
@vidakovic , I agree with you on the documentation part, IMO there should be
a checkpoint before a major feature goes in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
