adamsaghy commented on code in PR #3472:
URL: https://github.com/apache/fineract/pull/3472#discussion_r1336868462
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanOfficerAssignmentHistory.java:
##########
@@ -72,16 +73,16 @@ public void updateEndDate(final LocalDate endDate) {
this.endDate = endDate;
}
- public boolean matchesStartDateOf(final LocalDate matchingDate) {
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -625,7 +626,7 @@ public Money writeOffOutstandingPenaltyCharges(final
LocalDate transactionDate,
}
public boolean isOverdueOn(final LocalDate date) {
- return getDueDate().isBefore(date);
+ return DateUtils.isAfter(date, getDueDate());
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
##########
fineract-provider/src/main/java/org/apache/fineract/batch/command/internal/AdjustLoanTransactionByExternalIdCommandStrategy.java:
##########
@@ -45,7 +45,7 @@
*/
@Component
@RequiredArgsConstructor
-public class AdjustTransactionByExternalIdCommandStrategy implements
CommandStrategy {
+public class AdjustLoanTransactionByExternalIdCommandStrategy implements
CommandStrategy {
/**
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
