adamsaghy commented on code in PR #3472:
URL: https://github.com/apache/fineract/pull/3472#discussion_r1336869083
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/DepositAccountTermAndPreClosure.java:
##########
@@ -315,11 +316,7 @@ public boolean isTransferInterestToLinkedAccount() {
}
public boolean isAfterExpectedFirstDepositDate(final LocalDate
compareDate) {
- boolean isAfterExpectedFirstDepositDate = false;
- if (this.expectedFirstDepositOnDate != null) {
- isAfterExpectedFirstDepositDate =
compareDate.isAfter(getExpectedFirstDepositOnDate());
- }
- return isAfterExpectedFirstDepositDate;
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
