adamsaghy commented on code in PR #3472:
URL: https://github.com/apache/fineract/pull/3472#discussion_r1336868833
##########
fineract-provider/src/main/java/org/apache/fineract/batch/command/internal/AdjustLoanTransactionCommandStrategy.java:
##########
@@ -44,7 +44,7 @@
*/
@Component
@RequiredArgsConstructor
-public class AdjustTransactionCommandStrategy implements CommandStrategy {
+public class AdjustLoanTransactionCommandStrategy implements CommandStrategy {
/**
* Loan transactions api resource {@link LoanTransactionsApiResource}.
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
##########
fineract-provider/src/main/java/org/apache/fineract/batch/command/internal/GetLoanTransactionByExternalIdCommandStrategy.java:
##########
@@ -48,7 +48,7 @@
*/
@Component
@RequiredArgsConstructor
-public class GetTransactionByExternalIdCommandStrategy implements
CommandStrategy {
+public class GetLoanTransactionByExternalIdCommandStrategy implements
CommandStrategy {
/**
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
##########
fineract-provider/src/main/java/org/apache/fineract/batch/command/internal/GetLoanTransactionByIdCommandStrategy.java:
##########
@@ -47,7 +47,7 @@
*/
@Component
@RequiredArgsConstructor
-public class GetTransactionByIdCommandStrategy implements CommandStrategy {
+public class GetLoanTransactionByIdCommandStrategy implements CommandStrategy {
/**
Review Comment:
Arent these changes irrelevant to
[FINERACT-1921](https://issues.apache.org/jira/browse/FINERACT-1921)? Please
extract them into a separate PR if so!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
