adamsaghy commented on code in PR #3507:
URL: https://github.com/apache/fineract/pull/3507#discussion_r1371782169
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -963,6 +939,18 @@ public BigDecimal getAmount() {
return amount;
}
+ public boolean isBefore(final LocalDate date) {
+ return DateUtils.isBefore(getTransactionDate(), date);
+ }
+
+ public boolean isAfter(final LocalDate date) {
+ return DateUtils.isAfter(getTransactionDate(), date);
+ }
+
+ public boolean isOn(final LocalDate date) {
Review Comment:
Personnaly i prefer isEqual... :/
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -963,6 +939,18 @@ public BigDecimal getAmount() {
return amount;
}
+ public boolean isBefore(final LocalDate date) {
+ return DateUtils.isBefore(getTransactionDate(), date);
+ }
+
+ public boolean isAfter(final LocalDate date) {
+ return DateUtils.isAfter(getTransactionDate(), date);
+ }
+
+ public boolean isOn(final LocalDate date) {
Review Comment:
Personally i prefer isEqual... :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
