marta-jankovics commented on code in PR #3507:
URL: https://github.com/apache/fineract/pull/3507#discussion_r1372293733
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -6670,7 +6663,7 @@ public Money[] retriveIncomeOutstandingTillDate(final
LocalDate paymentDate) {
paidFromFutureInstallments =
paidFromFutureInstallments.plus(balancesForCurrentPeroid[4])
.minus(balancesForCurrentPeroid[2]);
}
- } else if (installment.getDueDate().isAfter(paymentDate)) {
Review Comment:
Yes, I am sure.
Before this else branch we checked these conditions already:
!DateUtils.isBefore(paymentDate, installment.getDueDate())
DateUtils.isAfter(paymentDate, installment.getFromDate())
so this check was redundant and not needed:
DateUtils.isBefore(paymentDate, installment.getDueDate())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
