marta-jankovics commented on code in PR #3507:
URL: https://github.com/apache/fineract/pull/3507#discussion_r1372297135


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -963,6 +939,18 @@ public BigDecimal getAmount() {
         return amount;
     }
 
+    public boolean isBefore(final LocalDate date) {
+        return DateUtils.isBefore(getTransactionDate(), date);
+    }
+
+    public boolean isAfter(final LocalDate date) {
+        return DateUtils.isAfter(getTransactionDate(), date);
+    }
+
+    public boolean isOn(final LocalDate date) {

Review Comment:
   I think isEqual would be misleading, because the transaction itself is not 
equal with a date, it was just performed on that date. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to