adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374662341
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -1326,15 +1326,15 @@ private PutLoanProductsProductIdRequest() {}
@Schema(example = "false")
public Boolean useBorrowerCycle;
@Schema(example = "2")
- public Integer repaymentFrequencyType;
+ public Long repaymentFrequencyType;
Review Comment:
This looks wrong to me hence this field is the ordinal of an enum.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -1415,7 +1415,7 @@ private PutLoanProductsProductIdRequest() {}
// Accounting
@Schema(example = "3")
- public Integer accountingRule;
+ public Long accountingRule;
Review Comment:
This looks wrong to me based on EnumOptionData id field type is Long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
