adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374652913
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResourceSwagger.java:
##########
@@ -1330,11 +1330,11 @@ private PutLoansLoanIdChanges() {}
@Schema
public String dueDate;
@Schema(example = "1")
- public Integer chargeTimeType;
+ public Long chargeTimeType;
Review Comment:
This looks wrong to me based on it is the ordinal of an enum.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResourceSwagger.java:
##########
@@ -1364,7 +1364,7 @@ private PutLoansLoanIdDisbursementData() {}
@Schema(example = "1")
public BigDecimal netDisbursalAmount;
@Schema(example = "1")
- public Integer interestType;
+ public Long interestType;
Review Comment:
This looks wrong to me based on it is the ordinal of an enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
