adamsaghy commented on code in PR #3545:
URL: https://github.com/apache/fineract/pull/3545#discussion_r1374650394
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResourceSwagger.java:
##########
@@ -1126,23 +1126,23 @@ private PostLoansRequest() {}
@Schema(example = "12")
public Integer loanTermFrequency;
@Schema(example = "2")
- public Integer loanTermFrequencyType;
+ public Long loanTermFrequencyType;
@Schema(example = "12")
public Integer numberOfRepayments;
@Schema(example = "1")
public Integer repaymentEvery;
@Schema(example = "2")
- public Integer repaymentFrequencyType;
+ public Long repaymentFrequencyType;
Review Comment:
This looks wrong to me based on LoanScheduleAssembler line 194. It is the
ordinal of an enum.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResourceSwagger.java:
##########
@@ -1126,23 +1126,23 @@ private PostLoansRequest() {}
@Schema(example = "12")
public Integer loanTermFrequency;
@Schema(example = "2")
- public Integer loanTermFrequencyType;
+ public Long loanTermFrequencyType;
@Schema(example = "12")
public Integer numberOfRepayments;
@Schema(example = "1")
public Integer repaymentEvery;
@Schema(example = "2")
- public Integer repaymentFrequencyType;
+ public Long repaymentFrequencyType;
@Schema(example = "2")
public Integer interestRatePerPeriod;
@Schema(example = "1")
- public Integer amortizationType;
+ public Long amortizationType;
Review Comment:
This looks wrong to me based on LoanScheduleAssembler line 200. It is the
ordinal of an enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
