reluxa commented on code in PR #3595:
URL: https://github.com/apache/fineract/pull/3595#discussion_r1401702511
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanDelinquencyRangeChangeBusinessEventSerializer.java:
##########
@@ -104,7 +116,80 @@ public <T> ByteBufferSerializable
toAvroDTO(BusinessEvent<T> rawEvent) {
.setAmount(amount)//
.setCurrency(currencyMapper.map(data.getCurrency()))//
.setDelinquentDate(delinquentDate)//
- .build();
+
.setInstallmentDelinquencyBuckets(installmentsDelinquencyData)//
Review Comment:
I think it might make sense to cover the logic which assembles
installmentsDelinquencyData with a few unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
