reluxa commented on code in PR #3595:
URL: https://github.com/apache/fineract/pull/3595#discussion_r1401712809
##########
fineract-avro-schemas/src/main/avro/loan/v1/LoanInstallmentDelinquencyBucketDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "LoanInstallmentDelinquencyBucketDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "delinquencyRange",
+ "type": [
+ "null",
+ "org.apache.fineract.avro.loan.v1.DelinquencyRangeDataV1"
Review Comment:
According to the design the fields here should have been moved up, like
`installmentDelinquencyBuckets[n].minimumAgeDays` and yours is
`installmentDelinquencyBuckets[n].delinquencyRange.minimumAgeDays` I think it's
perfectly fine, but please update the documentation to make it inline with the
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
