reluxa commented on code in PR #3595:
URL: https://github.com/apache/fineract/pull/3595#discussion_r1403075538
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanDelinquencyRangeChangeBusinessEventSerializer.java:
##########
@@ -104,7 +116,79 @@ public <T> ByteBufferSerializable
toAvroDTO(BusinessEvent<T> rawEvent) {
.setAmount(amount)//
.setCurrency(currencyMapper.map(data.getCurrency()))//
.setDelinquentDate(delinquentDate)//
- .build();
+
.setInstallmentDelinquencyBuckets(installmentsDelinquencyData).build();
Review Comment:
This should be calculated and set only when the installment level
delinquency is enabled on the loan.
https://github.com/apache/fineract/blob/f089f011168e09abeedc53313bde2b24c4239da2/fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java#L213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
