marta-jankovics commented on PR #3649: URL: https://github.com/apache/fineract/pull/3649#issuecomment-1874821768
> I have reviewed the code and it is Ok for the create client maker-checker action. > > Is there a way to include in the integration test case some coverage for Loan, Savings, Transaction (disbursement, withdrawal/deposit)? > > This is because I think that this is an important feature enhancement. Thank you for your review. I chose CREATE_CLIENT because it is one of the most complicated cases. The request and the command is made for CREATE_CLIENT which is not maker-checker, but ACTIVATE_CLIENT, which runs hidden as a side-action, is maker-checker. So when you try to approve the maker CREATE_CLIENT command request, it should be successful, even if the main action is not 'maker'. For your request I've added now one more test case, which is more simpler: WITHDRAWAL_SAVINGSACCOUNT. It is a real maker-checker transaction level action, on Savings Account main entity. If 4 eye is working for both of these cases then I do not think that any more tests are required, because the concept is the same for all other entities/actions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
