adamsaghy commented on code in PR #3649:
URL: https://github.com/apache/fineract/pull/3649#discussion_r1447287030
##########
fineract-core/src/main/java/org/apache/fineract/batch/service/BatchApiServiceImpl.java:
##########
@@ -346,6 +324,15 @@ private BatchResponse buildErrorResponse(Throwable ex,
BatchRequest request) {
return buildErrorResponse(requestId, statusCode, body, headers);
}
+ private BatchResponse buildOrThrowErrorResponse(RuntimeException ex,
BatchRequest request) {
+ BatchResponse response = buildErrorResponse(ex, request);
+ if (response.getStatusCode() != SC_OK &&
BatchRequestContextHolder.isEnclosingTransaction()) {
Review Comment:
Are you sure we dont need to throw error if the `enclosingTransaction =
false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
