adamsaghy commented on code in PR #3649:
URL: https://github.com/apache/fineract/pull/3649#discussion_r1447297190


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/savings/SavingsImportHandler.java:
##########
@@ -147,7 +148,9 @@ private SavingsAccountData readSavings(final Workbook 
workbook, final Row row, f
         Long interestPostingPeriodTypeId = null;
         EnumOptionData interestPostingPeriodTypeEnum = null;
         if (interestPostingPeriodType != null) {
-            if (interestPostingPeriodType.equalsIgnoreCase(MONTHLY)) {
+            if (interestPostingPeriodType.equalsIgnoreCase(DAILY)) {

Review Comment:
   This seems out of context. Would you mind to create a separate PR for this? 
It has not much to do with 4 eye principle and maker-checker handling



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to