Zeyad2003 commented on code in PR #3915:
URL: https://github.com/apache/fineract/pull/3915#discussion_r1694150473
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java:
##########
@@ -138,9 +138,6 @@ protected void doFilterInternal(HttpServletRequest request,
HttpServletResponse
}
if (!FIRST_REQUEST_PROCESSED) {
- final String baseUrl =
request.getRequestURL().toString().replace(request.getPathInfo(), "/");
Review Comment:
How to use spring built-in vars?
I tried this but didn't work:
```properties
# FINERACT-914
server.forward-headers-strategy=framework
server.port=${FINERACT_SERVER_PORT:8443}
server.address=${FINERACT_SERVER_ADDRESS:localhost}
server.servlet.context-path=${FINERACT_SERVER_SERVLET_CONTEXT_PATH:/fineract-provider}
server.compression.enabled=${FINERACT_SERVER_COMPRESSION_ENABLED:true}
# backwards compatibility for
'org.apache.fineract.infrastructure.security.filter.TenantAwareBasicAuthenticationFilter
baseUrl=https://${server.address}:${server.port}${server.servlet.context-path}
```
and the checks failed as following:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
