adamsaghy commented on code in PR #3915:
URL: https://github.com/apache/fineract/pull/3915#discussion_r1666520520
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java:
##########
@@ -138,9 +138,6 @@ protected void doFilterInternal(HttpServletRequest request,
HttpServletResponse
}
if (!FIRST_REQUEST_PROCESSED) {
- final String baseUrl =
request.getRequestURL().toString().replace(request.getPathInfo(), "/");
Review Comment:
Not really a fan of having hardcoded URL anywhere
`https://localhost:8443${FINERACT_SERVER_SERVLET_CONTEXT_PATH:/fineract-provider}`
but i am leaving to Aleks to decide on this one. I dont think leaving the
`final String baseUrl =
request.getRequestURL().toString().replace(request.getPathInfo(), "/");` would
cause any harm, but i might be missing something,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
