vidakovic commented on code in PR #3915:
URL: https://github.com/apache/fineract/pull/3915#discussion_r1666766486
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java:
##########
@@ -138,9 +138,6 @@ protected void doFilterInternal(HttpServletRequest request,
HttpServletResponse
}
if (!FIRST_REQUEST_PROCESSED) {
- final String baseUrl =
request.getRequestURL().toString().replace(request.getPathInfo(), "/");
Review Comment:
@adamsaghy ... we can improve that setting; I think there are spring
built-in vars/properties for the host and the port... that way it won't be
hardcoded.
Note: there are 2 reasons to replace that piece of code. First it just plain
doesn't work when we introduce Spring Web MVC. Second, application.properties
should be the only source of truth (there might be more examples like this and
should be treated the same, for another day).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
