adamsaghy commented on code in PR #4171:
URL: https://github.com/apache/fineract/pull/4171#discussion_r1846653041
##########
fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java:
##########
@@ -241,7 +241,7 @@ private boolean isLockOverrulable(LoanAccountLock
loanAccountLock) {
if (isBypassUser()) {
return true;
} else {
- return StringUtils.isNotBlank(loanAccountLock.getError());
+ return StringUtils.isBlank(loanAccountLock.getError());
Review Comment:
I dont think it is correct to do this. Please undo this change. We can
change the lock if we are going with bypass user or there was an error stored
on the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
