alberto-art3ch commented on code in PR #4171:
URL: https://github.com/apache/fineract/pull/4171#discussion_r1846786061
##########
fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java:
##########
@@ -241,7 +241,7 @@ private boolean isLockOverrulable(LoanAccountLock
loanAccountLock) {
if (isBypassUser()) {
return true;
} else {
- return StringUtils.isNotBlank(loanAccountLock.getError());
+ return StringUtils.isBlank(loanAccountLock.getError());
Review Comment:
Done! Change undone
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java:
##########
@@ -75,7 +77,9 @@ protected void doFilterInternal(HttpServletRequest request,
HttpServletResponse
proceed(filterChain, request, response);
} else {
try {
+ log.info("calculateRelevantLoanIds ==>");
Review Comment:
Done! Logs removed
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBFilterHelper.java:
##########
@@ -240,7 +250,8 @@ private Long getTopLevelLoanIdFromBatchRequest(BatchRequest
batchRequest) throws
private List<Long> getLoanIdsFromApi(String pathInfo) {
List<Long> loanIds = getLoanIdList(pathInfo);
- if (isLoanHardLocked(loanIds)) {
+ log.info("getLoanIdsFromApi {}", loanIds.size());
Review Comment:
Done! Logs removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
