adamsaghy commented on code in PR #4171:
URL: https://github.com/apache/fineract/pull/4171#discussion_r1846660337
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBFilterHelper.java:
##########
@@ -240,7 +250,8 @@ private Long getTopLevelLoanIdFromBatchRequest(BatchRequest
batchRequest) throws
private List<Long> getLoanIdsFromApi(String pathInfo) {
List<Long> loanIds = getLoanIdList(pathInfo);
- if (isLoanHardLocked(loanIds)) {
+ log.info("getLoanIdsFromApi {}", loanIds.size());
+ if (isLoanHardLocked(loanIds) && isLockOverrulable(loanIds)) {
Review Comment:
Wrong condition. If the lock has an error stored, we should allow to run the
inline cob!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
