adamsaghy commented on code in PR #4442:
URL: https://github.com/apache/fineract/pull/4442#discussion_r1996043348
##########
fineract-provider/src/main/java/org/apache/fineract/useradministration/service/UserDataValidator.java:
##########
@@ -124,11 +124,6 @@ public void validateForCreate(final String json) {
final Long officeId =
this.fromApiJsonHelper.extractLongNamed(OFFICE_ID, element);
baseDataValidator.reset().parameter(OFFICE_ID).value(officeId).notNull().integerGreaterThanZero();
- if (this.fromApiJsonHelper.parameterExists(STAFF_ID, element)) {
Review Comment:
This was optional check... if the staffId was not part of the request, there
was no validation... if staffId is there, it should validate. I dont think
removing this is correct course of action!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
