adamsaghy commented on code in PR #4487:
URL: https://github.com/apache/fineract/pull/4487#discussion_r2005709480
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/serialization/GroupingTypesDataValidator.java:
##########
@@ -177,17 +177,17 @@ public void validateForCreateCenterGroup(final
JsonCommand command) {
baseDataValidator.reset().parameter(GroupingTypesApiConstants.externalIdParamName).value(externalId).notExceedingLengthOf(100);
}
- final Long centerId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.centerIdParamName,
element);
-
baseDataValidator.reset().parameter(GroupingTypesApiConstants.centerIdParamName).value(centerId).notNull().integerGreaterThanZero();
+ // final Long centerId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.centerIdParamName,
element);
Review Comment:
Why to remove?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/serialization/GroupingTypesDataValidator.java:
##########
@@ -177,17 +177,17 @@ public void validateForCreateCenterGroup(final
JsonCommand command) {
baseDataValidator.reset().parameter(GroupingTypesApiConstants.externalIdParamName).value(externalId).notExceedingLengthOf(100);
}
- final Long centerId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.centerIdParamName,
element);
-
baseDataValidator.reset().parameter(GroupingTypesApiConstants.centerIdParamName).value(centerId).notNull().integerGreaterThanZero();
+ // final Long centerId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.centerIdParamName,
element);
+ //
baseDataValidator.reset().parameter(GroupingTypesApiConstants.centerIdParamName).value(centerId).notNull().integerGreaterThanZero();
// office is inherited from center
final Long officeId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.officeIdParamName,
element);
baseDataValidator.reset().parameter(GroupingTypesApiConstants.officeIdParamName).value(officeId).notNull().integerGreaterThanZero();
- if
(this.fromApiJsonHelper.parameterExists(GroupingTypesApiConstants.staffIdParamName,
element)) {
- final Long staffId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.staffIdParamName,
element);
-
baseDataValidator.reset().parameter(GroupingTypesApiConstants.staffIdParamName).value(staffId).integerGreaterThanZero();
- }
+ // if
(this.fromApiJsonHelper.parameterExists(GroupingTypesApiConstants.staffIdParamName,
element)) {
Review Comment:
Why to remove?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/serialization/GroupingTypesDataValidator.java:
##########
@@ -251,10 +251,10 @@ public void validateForCreateGroup(final JsonCommand
command) {
final Long officeId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.officeIdParamName,
element);
baseDataValidator.reset().parameter(GroupingTypesApiConstants.officeIdParamName).value(officeId).notNull().integerGreaterThanZero();
- if
(this.fromApiJsonHelper.parameterExists(GroupingTypesApiConstants.staffIdParamName,
element)) {
- final Long staffId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.staffIdParamName,
element);
-
baseDataValidator.reset().parameter(GroupingTypesApiConstants.staffIdParamName).value(staffId).integerGreaterThanZero();
- }
+ // if
(this.fromApiJsonHelper.parameterExists(GroupingTypesApiConstants.staffIdParamName,
element)) {
Review Comment:
Why to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
