danielales2541 commented on code in PR #4487:
URL: https://github.com/apache/fineract/pull/4487#discussion_r2008498295
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/serialization/GroupingTypesDataValidator.java:
##########
@@ -251,10 +251,10 @@ public void validateForCreateGroup(final JsonCommand
command) {
final Long officeId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.officeIdParamName,
element);
baseDataValidator.reset().parameter(GroupingTypesApiConstants.officeIdParamName).value(officeId).notNull().integerGreaterThanZero();
- if
(this.fromApiJsonHelper.parameterExists(GroupingTypesApiConstants.staffIdParamName,
element)) {
- final Long staffId =
this.fromApiJsonHelper.extractLongNamed(GroupingTypesApiConstants.staffIdParamName,
element);
-
baseDataValidator.reset().parameter(GroupingTypesApiConstants.staffIdParamName).value(staffId).integerGreaterThanZero();
- }
+ // if
(this.fromApiJsonHelper.parameterExists(GroupingTypesApiConstants.staffIdParamName,
element)) {
Review Comment:
In Excel, it asks for a center name, which pulls the center ID, but this
does not appear as mandatory. With this, the validation makes it mandatory,
interrupting the creation of groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
