Vectorquantiy commented on code in PR #4542:
URL: https://github.com/apache/fineract/pull/4542#discussion_r2044656813


##########
fineract-core/src/main/java/org/apache/fineract/useradministration/domain/Permission.java:
##########
@@ -43,12 +43,16 @@ public class Permission extends 
AbstractPersistableCustom<Long> implements Seria
     @Column(name = "can_maker_checker", nullable = false)
     private boolean canMakerChecker;
 
+    @Column(name = "is_replayable", nullable = false)

Review Comment:
   See my explanation at the flag itself.



##########
fineract-core/src/main/java/org/apache/fineract/commands/service/CommandSourceService.java:
##########
@@ -111,6 +120,9 @@ public CommandSource findCommandSource(CommandWrapper 
wrapper, String idempotenc
     public CommandSource getInitialCommandSource(CommandWrapper wrapper, 
JsonCommand jsonCommand, AppUser maker, String idempotencyKey) {
         CommandSource commandSourceResult = 
CommandSource.fullEntryFrom(wrapper, jsonCommand, maker, idempotencyKey,
                 UNDER_PROCESSING.getValue());
+        if 
(!configurationDomainService.isReplayable(wrapper.taskPermissionName())) {

Review Comment:
   See my explanation at the flag itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to