Vectorquantiy commented on code in PR #4542:
URL: https://github.com/apache/fineract/pull/4542#discussion_r2044654815


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -60,6 +60,18 @@ public boolean isMakerCheckerEnabledForTask(final String 
taskPermissionCode) {
         return false;
     }
 
+    @Override
+    public boolean isReplayable(final String taskPermissionCode) {

Review Comment:
    In my opinion the isReplayable flag is still needed. From 4 eye checker 
perspective I would like to leave mark at the command, which says that the 
original command_as_json data has been modified. As a result these kind of 
commands are not replayable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to