oleksii-novikov-onix commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2051087156
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull
RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod
repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
In my opinion, using `@NotNull` here is a mistake. Jakarta validation
annotations are intended for runtime validation, which does not apply in this
case. For static analysis, it is better to use Spring annotations instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
