adamsaghy commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2054138459
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull
RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod
repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
Agree there is some confusion around which NotNull / NonNull annotation to
be used. Let me create a follow up story for this, but in the meantime we can
use the proper one here
(NonNull)https://issues.apache.org/jira/browse/FINERACT-2267
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull
RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod
repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
Agree there is some confusion around which NotNull / NonNull annotation to
be used. Let me create a follow up story for this, but in the meantime we can
use the proper one here (NonNull)
https://issues.apache.org/jira/browse/FINERACT-2267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
