somasorosdpc commented on code in PR #4594:
URL: https://github.com/apache/fineract/pull/4594#discussion_r2053680589
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/data/InterestPeriod.java:
##########
@@ -89,6 +89,13 @@ public static InterestPeriod withEmptyAmounts(@NotNull
RepaymentPeriod repayment
zero.getMc(), false);
}
+ public static InterestPeriod withEmptyAmounts(@NotNull RepaymentPeriod
repaymentPeriod, @NotNull LocalDate fromDate, LocalDate dueDate,
Review Comment:
I've checked the whole feature of EMI calculator and I've found that we are
using Jakarta validation annotations only. I'm not sure, what was the original
purpose of it. I think we should start a new conversation about validation,
because It looks way bigger change than a simple refactor for a feature fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
