adamsaghy commented on code in PR #4626:
URL: https://github.com/apache/fineract/pull/4626#discussion_r2063625530
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/fund/data/FundData.java:
##########
@@ -34,13 +34,17 @@ public final class FundData implements Serializable {
@SuppressWarnings("unused")
private final String externalId;
- public static FundData instance(final Long id, final String name, final
String externalId) {
- return new FundData(id, name, externalId);
+ private final Boolean isActive;
+
+ public static FundData instance(final Long id, final String name, final
String externalId, final Boolean isActive) {
+ return new FundData(id, name, externalId, isActive);
}
- private FundData(final Long id, final String name, final String
externalId) {
+ private FundData(final Long id, final String name, final String
externalId, final Boolean isActive) {
this.id = id;
this.name = name;
this.externalId = externalId;
+ this.isActive = isActive;
}
+ public String getName(){return this.name; } //for testing
Review Comment:
There is already lombok getter, so no need for this method...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
