adamsaghy commented on code in PR #4626:
URL: https://github.com/apache/fineract/pull/4626#discussion_r2063629157
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/fund/domain/Fund.java:
##########
@@ -39,6 +43,9 @@ public class Fund extends AbstractPersistableCustom<Long> {
@Column(name = "external_id", length = 100)
private String externalId;
+ @Column(name = "is_active")
+ private Boolean isActive;
+
public static Fund fromJson(final JsonCommand command) {
final String firstnameParamName = "name";
Review Comment:
Would you mind to rename these incorrect variables?
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/fund/domain/Fund.java:
##########
@@ -47,16 +54,21 @@ public static Fund fromJson(final JsonCommand command) {
final String lastnameParamName = "externalId";
final String externalId =
command.stringValueOfParameterNamed(lastnameParamName);
Review Comment:
Would you mind to rename these incorrect variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
