adamsaghy commented on code in PR #4626:
URL: https://github.com/apache/fineract/pull/4626#discussion_r2063631187
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/fund/domain/Fund.java:
##########
@@ -47,16 +54,21 @@ public static Fund fromJson(final JsonCommand command) {
final String lastnameParamName = "externalId";
final String externalId =
command.stringValueOfParameterNamed(lastnameParamName);
- return new Fund(name, externalId);
+ final String archiveParamName = "isActive";
Review Comment:
archiveParamName and "isActive" looks not correct. Would you mind to rename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
