adamsaghy commented on code in PR #4651:
URL: https://github.com/apache/fineract/pull/4651#discussion_r2101988944


##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanRepaymentStepDef.java:
##########
@@ -550,7 +550,7 @@ public void amountsEquallyDistributedInSchedule(double 
totalAmount) throws IOExc
         BigDecimal lastExpectedAmount = new 
BigDecimal(totalAmount).setScale(0, RoundingMode.HALF_DOWN);
 
         for (int i = 1; i < periods.size(); i++) {
-            BigDecimal actualAmount = new 
BigDecimal(periods.get(i).getPrincipalOriginalDue()).setScale(0, 
RoundingMode.HALF_DOWN);
+            BigDecimal actualAmount = 
periods.get(i).getPrincipalOriginalDue().setScale(0, RoundingMode.HALF_DOWN);

Review Comment:
   I think this is a bug. 0 scale means we can only have whole numbers... go 
with 2 at least please!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to