Cocoa-Puffs commented on code in PR #4651:
URL: https://github.com/apache/fineract/pull/4651#discussion_r2102323765
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java:
##########
@@ -464,6 +464,7 @@ private Integer importLoanRepayment(final
List<LoanTransactionData> loanRepaymen
JsonObject loanRepaymentJsonob =
gsonBuilder.create().toJsonTree(loanRepayments.get(rowIndex)).getAsJsonObject();
loanRepaymentJsonob.remove("manuallyReversed");
loanRepaymentJsonob.remove("numberOfRepayments");
+ loanRepaymentJsonob.remove("reversed");
Review Comment:
During this part of the loan import we create a json object made from
LoanTransactionData objects, however there are certain fields that the loan
import validates for, that cannot exist in the json object during import.
Reversed is one of these fields and since I added it to the LoanTransactionData
at one point the tests related to loan imports started failing. I found this
part, where we do the same with the "manuallyReversed" and "numberOfRepayments"
fields. However since I removed the reversed field from LoanTransactionData we
don't need this. I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
